Azure python sdk url summary upstream#20563
Open
bdrodes wants to merge 13 commits intogithub:mainfrom
Open
Conversation
Contributor
bdrodes
commented
Sep 30, 2025
bdrodes
commented
- Added MaD sinks for URLs in the azure SDK, labeled as 'ssrf'
- Updated HTTP request clients to use 'ssrf' MaD
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Server-Side Request Forgery (SSRF) modeling for the Azure Python SDK by introducing MaD (Models as Data) sinks and updating HTTP request clients to recognize SSRF vulnerabilities. This enables CodeQL to detect when user input can control URLs passed to Azure SDK methods.
- Added SSRF sink modeling framework for MaD-based HTTP requests
- Created comprehensive Azure SDK models for KeyVault and Storage services
- Added test coverage for Azure client SSRF scenarios
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| python/ql/lib/semmle/python/frameworks/SSRFSink.qll | New framework for handling SSRF sinks through MaD models |
| python/ql/lib/semmle/python/frameworks/Azure.Storage.model.yml | MaD definitions for Azure Storage SDK SSRF sinks |
| python/ql/lib/semmle/python/frameworks/Azure.Keyvault.model.yml | MaD definitions for Azure KeyVault SDK SSRF sinks |
| python/ql/lib/semmle/python/Frameworks.qll | Import statement for new SSRFSink framework |
| python/ql/test/query-tests/Security/CWE-918-ServerSideRequestForgery/test_azure_client.py | Test cases for Azure SDK SSRF detection |
| python/ql/test/query-tests/Security/CWE-918-ServerSideRequestForgery/PartialServerSideRequestForgery.expected | Expected results for partial SSRF tests |
| python/ql/test/query-tests/Security/CWE-918-ServerSideRequestForgery/FullServerSideRequestForgery.expected | Expected results for full SSRF tests |
| python/ql/lib/change-notes/released/2025-09-30-azure_ssrf_models | Release notes for the changes |
python/ql/test/query-tests/Security/CWE-918-ServerSideRequestForgery/test_azure_client.py
Outdated
Show resolved
Hide resolved
python/ql/test/query-tests/Security/CWE-918-ServerSideRequestForgery/test_azure_client.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…orgery/test_azure_client.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…orgery/test_azure_client.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
owen-mc
requested changes
Feb 4, 2026
Contributor
owen-mc
left a comment
owen-mc
left a comment
There was a problem hiding this comment.
I'm not familiar with the python library in general, but I can review the use of models-as-data.
| or | ||
| this.getArgByName(_) = urlArg | ||
| ) and | ||
| urlArg = ModelOutput::getASinkNode("ssrf").asSink() |
Contributor
There was a problem hiding this comment.
- Some tests are failing because we do validation on sink kinds and "ssrf" isn't on the list. Please use "request-forgery", which is what all the other languages use. (New sink kinds can of course be added, but if there is an existing one then that should be used first, to keep the different language libraries consistent.)
- In Python: MaD barriers #21004 we switched to using a slightly different syntax (which matches the static languages). You'll have to rebase on
mainfor this to work.
Suggested change
| urlArg = ModelOutput::getASinkNode("ssrf").asSink() | |
| ModelOutput::sinkNode(urlArg, "request-forgery") |
Contributor
|
Looking at the other test failures (which aren't related to validation of sink kinds):
|
…t cases expected results, off by one line. Changed to using ModelOutput::sinkNode.
Contributor
Author
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.